Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding emi package #29399

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Adding emi package #29399

wants to merge 10 commits into from

Conversation

fvalle1
Copy link
Contributor

@fvalle1 fvalle1 commented Mar 11, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@fvalle1
Copy link
Contributor Author

fvalle1 commented Mar 11, 2025

I'm ok to be listed here

@fvalle1
Copy link
Contributor Author

fvalle1 commented Mar 11, 2025

@LeonardoAgasso

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/meta.yaml:
    • lints:
      • Please put your recipe in its own directory in the recipes/ directory as recipe/<name of feedstock>/<your recipe file>.yaml.

@LeonardoAgasso
Copy link

I'm ok to be listed here

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/emi/meta.yaml) and found some lint.

Here's what I've got...

For recipes/emi/meta.yaml:

  • ❌ The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about'].
  • ❌ The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • ❌ The about section contained an unexpected subsection name. extra is not a valid subsection name.

For recipes/emi/meta.yaml:

  • ℹ️ libgcc-ng has been superseded by libgcc. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("c") }} and {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("c") }}    # depending on which...
        - {{ compiler("cxx") }}  # ... compilers you use
  • ℹ️ libstdcxx-ng has been superseded by libstdcxx. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("cxx") }}
  • ℹ️ Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [6].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13790603503. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/emi/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/emi/meta.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [6].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13831173997. Examine the logs at this URL for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants