Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NVIDIA TransformerEngine #29403

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pstjohn
Copy link
Contributor

@pstjohn pstjohn commented Mar 11, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@pstjohn pstjohn changed the title initial attempt at transformer engine recipe Add NVIDIA TransformerEngine Mar 11, 2025
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/transformer-engine/meta.yaml) and found some lint.

Here's what I've got...

For recipes/transformer-engine/meta.yaml:

  • requirements: host: importlib-metadata>=1.0 must contain a space between the name and the pin, i.e. importlib-metadata >=1.0
  • requirements: run: importlib-metadata>=1.0 must contain a space between the name and the pin, i.e. importlib-metadata >=1.0

For recipes/transformer-engine/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.
  • ℹ️ top-level output has some malformed specs:
  • In section build: `pytorch ==cuda
  • In section host: pytorch =*=cuda*, importlib-metadata>=1.0
  • In section run: `importlib-metadata>=1.0
  • In section run_constrained: pytorch =*=cuda* Requirement spec fields should always be space-separated to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13796775976. Examine the logs at this URL for more detail.

Signed-off-by: Peter St. John <[email protected]>
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/transformer-engine/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/transformer-engine/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.
  • ℹ️ top-level output has some malformed specs:
  • In section build: `pytorch ==cuda
  • In section host: `pytorch ==cuda
  • In section run_constrained: pytorch =*=cuda* Requirement spec fields should always be space-separated to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13797628587. Examine the logs at this URL for more detail.

Signed-off-by: Peter St. John <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants