Skip to content

Add smspp-project to conda-forge #29920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 129 commits into
base: main
Choose a base branch
from

Conversation

davide-f
Copy link
Contributor

@davide-f davide-f commented May 3, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented May 3, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/smspp-project/meta.yaml) and found some lint.

Here's what I've got...

For recipes/smspp-project/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [41, 45, 46, 47, 48, 49, 62, 63, 64, 65, 66]

For recipes/smspp-project/meta.yaml:

  • ℹ️ The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.
  • ℹ️ You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.
  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

  • ℹ️ top-level output has some malformed specs:
  • In section build: pkgconfig [unix]
  • In section host: mpich [unix], msmpi [win], _openmp_mutex [linux], netcdf4 [win], netcdf-cxx4 [not win]
  • In section run: mpich [unix], msmpi [win], _openmp_mutex [linux], netcdf4 [win], netcdf-cxx4 [not win]
    Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8 should be python >=3.8.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14815709742. Examine the logs at this URL for more detail.

Copy link
Contributor

github-actions bot commented May 3, 2025

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • LICENSE.txt:
    • lints:
      • Do not edit files outside of the recipes/ directory.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented May 4, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/smspp-project/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/smspp-project/meta.yaml:

  • ℹ️ You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.
  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16367005193. Examine the logs at this URL for more detail.

@davide-f
Copy link
Contributor Author

davide-f commented May 4, 2025

Hello @dmeoli and @frangio68 :)

Can you confirm by writing a message here that you wish to become maintainer of this future recipe?

@dmeoli
Copy link

dmeoli commented May 4, 2025

Hello @dmeoli and @frangio68 :)

Can you confirm by writing a message here that you wish to become maintainer of this future recipe?

Sure! I confirm that I wish to become the maintainer of this future recipe.

@frangio68
Copy link

Hello @dmeoli and @frangio68 :)

Can you confirm by writing a message here that you wish to become maintainer of this future recipe?

Sure :-)

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/smspp-project/meta.yaml) and found some lint.

Here's what I've got...

For recipes/smspp-project/meta.yaml:

  • ❌ pin_compatible should be used instead of pin_subpackage for stopt because it is not a known output of this recipe: ['smspp-project'].

For recipes/smspp-project/meta.yaml:

  • ℹ️ You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16696055364. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 2, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/smspp-project/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/smspp-project/meta.yaml:

  • ℹ️ You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16711001193. Examine the logs at this URL for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants