Skip to content

Rebuild for lz4_c 1.10 #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update lz4_c110.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12204362148 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jdblischak
Copy link
Member

@teo-tsirpanis could you please investigate why this latest lz4-c worked with tiledb 2.25 (#385) but failed on win-64 for 2.26? Error message below:

CMake Error at D:/bld/tiledb_1733513649514/_h_env/Library/lib/cmake/lz4/lz4Targets.cmake:97 (message):
  The imported target "LZ4::lz4_static" references the file

     "D:/bld/tiledb_1733513649514/_h_env/Library/lib/lz4_static.lib"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "D:/bld/tiledb_1733513649514/_h_env/Library/lib/cmake/lz4/lz4Targets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  D:/bld/tiledb_1733513649514/_h_env/Library/lib/cmake/lz4/lz4Config.cmake:26 (include)
  C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  cmake/Modules/FindLZ4.cmake:31 (find_package)
  C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  tiledb/sm/compressors/CMakeLists.txt:40 (find_package)

@teo-tsirpanis
Copy link
Member

In 2.26 as part of TileDB-Inc/TileDB#5021 the logic of finding lz4 was changed to try find_package first. The package exists but a library it references does not. This is not a problem of TileDB and has been reported over at lz4 in conda-forge/lz4-c-feedstock#35 (comment).

@jdblischak
Copy link
Member

In 2.26 ... the logic of finding lz4 was changed to try find_package first

@teo-tsirpanis Thanks for the explanation! That makes sense then why the other migration PR passed for 2.25

has been reported over at lz4

Hopefully they can fix this soon and upload a new lz4-c 1.10 conda binary. Then we should be able to simply restart the CI on this PR. Note that an Issue has been opened to track the problem, conda-forge/lz4-c-feedstock#36, but no PR has been opened yet.

I also saw this Issue about the name of the shared library on Windows changing from liblz4.lib to lz4.lib (conda-forge/conda-forge-pinning-feedstock#6808). Is this something we need to take any action on?

@teo-tsirpanis
Copy link
Member

CI is now green.

@teo-tsirpanis teo-tsirpanis merged commit 48c74c7 into conda-forge:main Dec 9, 2024
9 checks passed
@akrherz
Copy link
Contributor

akrherz commented Dec 9, 2024

I believe @jdblischak 's concerns above have been addressed and think gdal needs this migration to fix a dep issue with poppler 24.12. conda-forge/gdal-feedstock#1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants