-
-
Notifications
You must be signed in to change notification settings - Fork 15
Rebuild for lz4_c 1.10 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for lz4_c 1.10 #388
Conversation
…onda-forge-pinning 2024.12.06.19.20.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@teo-tsirpanis could you please investigate why this latest lz4-c worked with tiledb 2.25 (#385) but failed on win-64 for 2.26? Error message below: CMake Error at D:/bld/tiledb_1733513649514/_h_env/Library/lib/cmake/lz4/lz4Targets.cmake:97 (message):
The imported target "LZ4::lz4_static" references the file
"D:/bld/tiledb_1733513649514/_h_env/Library/lib/lz4_static.lib"
but this file does not exist. Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
"D:/bld/tiledb_1733513649514/_h_env/Library/lib/cmake/lz4/lz4Targets.cmake"
but not all the files it references.
Call Stack (most recent call first):
D:/bld/tiledb_1733513649514/_h_env/Library/lib/cmake/lz4/lz4Config.cmake:26 (include)
C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
cmake/Modules/FindLZ4.cmake:31 (find_package)
C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
tiledb/sm/compressors/CMakeLists.txt:40 (find_package) |
In 2.26 as part of TileDB-Inc/TileDB#5021 the logic of finding lz4 was changed to try |
@teo-tsirpanis Thanks for the explanation! That makes sense then why the other migration PR passed for 2.25
Hopefully they can fix this soon and upload a new lz4-c 1.10 conda binary. Then we should be able to simply restart the CI on this PR. Note that an Issue has been opened to track the problem, conda-forge/lz4-c-feedstock#36, but no PR has been opened yet. I also saw this Issue about the name of the shared library on Windows changing from liblz4.lib to lz4.lib (conda-forge/conda-forge-pinning-feedstock#6808). Is this something we need to take any action on? |
CI is now green. |
I believe @jdblischak 's concerns above have been addressed and think |
This PR has been triggered in an effort to update lz4_c110.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12204362148 - please use this URL for debugging.