Skip to content

Conversation

@conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Apr 12, 2025

Now that the XGBoost R test has been rewritten as part of the XGBoost 3 upgrade. Try re-enabling it on Windows to see if the flaky test issues have been resolved

Closes #205

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Apr 12, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ py-xgboost output has some malformed specs:
  • In section host: `libxgboost ==cpu_h_PKG_BUILDNUM
  • In section run: `libxgboost ==cpu_h_PKG_BUILDNUM
    xgboost output has some malformed specs:
  • In section host: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
  • In section run: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
    r-xgboost output has some malformed specs:
  • In section host: `libxgboost ==cpu_h_PKG_BUILDNUM
  • In section run: libxgboost =*=cpu_h*_PKG_BUILDNUM Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8should bepython >=3.8`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14414808064. Examine the logs at this URL for more detail.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review April 12, 2025 00:34
@jakirkham jakirkham marked this pull request as draft April 12, 2025 01:30
@jakirkham jakirkham changed the title MNT: rerender Readd R XGBoost test on Windows Apr 12, 2025
@trivialfis
Copy link

trivialfis commented Apr 12, 2025

Thank you for working on this. I was wondering why Windows is skipped when looking into the rapids fork.

Inspecting the log, I can't see the reason for the failure. Will try to reproduce.

Note:
log: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1223290&view=logs&j=f4756218-2105-5c4f-5cb9-a0ac2817b29f&t=618de3fb-810d-5a79-16ac-89d47be0c182&l=5103

@jakirkham
Copy link
Member

Tried restarting CI and we can see the failure in this Windows CI job (also attached log for posterity)

Have included a snippet of the failure below:

 $ data :Formal class 'dgCMatrix' [package "Matrix"] with 6 slots
  .. ..@ i       : int [1:143286] 2 6 8 11 18 20 21 24 28 32 ...
  .. ..@ p       : int [1:127] 0 369 372 3306 5845 6489 6513 8380 8384 10991 ...
  .. ..@ Dim     : int [1:2] 6513 126
  .. ..@ Dimnames:List of 2
  .. .. ..$ : NULL
  .. .. ..$ : chr [1:126] "cap-shape=bell" "cap-shape=conical" "cap-shape=convex" "cap-shape=flat" ...
  .. ..@ x       : num [1:143286] 1 1 1 1 1 1 1 1 1 1 ...
  .. ..@ factors : list()
 $ label: num [1:6513] 1 0 0 1 0 0 0 1 0 0 ...
[1] 6513  126
[1] 1611  126
[1] "dgCMatrix"
[1] "numeric"
[1] 1611
[1] 0.2852080 0.9240534 0.2852080 0.2852080 0.0516128 0.9240534
[1] 0 1 0 0 0 1
[1] "test-error= 0.0217256362507759"
[1]	train-logloss:0.233156	test-logloss:0.226460 
[2]	train-logloss:0.136542	test-logloss:0.137763 
[1] 1611
[1] 0.2852080 0.9240534 0.2852080 0.2852080 0.0516128 0.9240534
[1] 0 1 0 0 0 1
[1] "test-error= 0.0217256362507759"

@trivialfis
Copy link

I can reproduce the error log on Windows, but haven't figured out what is failing. @hcho3 shared that he would like to take a look when time allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R package test fails for Windows

3 participants