-
Notifications
You must be signed in to change notification settings - Fork 465
handle dynamic tags unknown to lief #5778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e00817b
to
f19b061
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much. This looks good to me.
CodSpeed Performance ReportMerging #5778 will not alter performanceComparing Summary
|
While some of the test failures are unrelated, e.g.: Others are possibly related? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great to me. Thank you @cbouss and @kenodegard
@cbouss let's work together to figure out why the tests are failing. |
I reviewed before that tests ran. Somehow they required manual approval to run so it looked liked all was green.
Description
Lief dynamic entry tags are defined here:
https://github.com/lief-project/LIEF/blob/main/include/LIEF/ELF/DynamicEntry.hpp#L47
We are seeing linux aarch64 binaries with tag TLSDESC_PLT, which is not defined in lief. lief stores that tag as a its hex value instead as an instance of lief.ELF.DynamicEntry.TAG.
conda build trips on this while looking for tag SONAME, with a
ValueError: 1879047926 is not a valid TAG.
, as described in this issue: #5665This is true for both lief 0.16.4 and 0.16.6.
Used workaround have been so far to:
overlinking_ignore_patterns
. Pkg 8275 oracle instant client latest AnacondaRecipes/oracle-instant-client-feedstock#1This change filters dynamic_entries to only valid instances of ELF_DYNAMIC_TAGS.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?