Skip to content

Conversation

jacobwilliams
Copy link

Fixes #5122

This PR includes the following changes:

  • Fixed the chunks algorithm for splitting up long command line calls. The old one was buggy and also used the wrong max length on windows.
  • A CONDA_BUILD_MAX_CMD_LEN can alternately be used to set the max cmd line length.
  • Otherwise, 8190 is now used on Windows, and 32760 otherwise. There were two different algorithms in two different places for this, so those have been consolidated. The routine was moved into utils and a new MAX_CMD_LINE_LENGTH variable added to hold this value.

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

The original algorithm could result in command line calls that were too large. For example, this was causing "The filename or extension is too long" errors on Windows for projects with many files.
Also added the ability to specify the max chunk size length to use via a CONDA_BUILD_MAX_CMD_LEN environment variable.
Fixes conda#5122
changed limits for max cmd line: 8190 for windows, 32760 otherwise. no consistent for both regex_files_rg and compile_missing_pyc
added MAX_CMD_LINE_LENGTH variable to avoid duplication
@jacobwilliams jacobwilliams requested a review from a team as a code owner August 31, 2025 02:52
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Aug 31, 2025
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @jacobwilliams.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1198), and ping the bot to refresh the PR.

@jacobwilliams
Copy link
Author

anybody home?

@travishathaway
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 8, 2025
Copy link

codspeed-hq bot commented Sep 8, 2025

CodSpeed Performance Report

Merging #5780 will not alter performance

Comparing jacobwilliams:main (d06c617) with main (ad762d6)

Summary

✅ 5 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

FileNotFoundError: [WinError 206] The filename or extension is too long

3 participants