-
Notifications
You must be signed in to change notification settings - Fork 15
Fixes #366 Seemingly unnecessary double quoting and escaping #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes #366 Seemingly unnecessary double quoting and escaping #379
Conversation
…-seemingly-unnecessary-double-quoting-an-escaping
…-seemingly-unnecessary-double-quoting-an-escaping
…-seemingly-unnecessary-double-quoting-an-escaping
This is why we have such lovely integration tests:
The change in its current state tanks the success rate for parsing |
It looks like comments/selectors on JINJA assignment lines are causing parsing issues with the current changes.
|
A brief test shows that I won't break this out into a new ticket, this needs to be addressed in these changes. |
…. Also adds some new comment support in crm convert
… quoting conditions with a new regex
… ends in a multiline string
Nice. The PR will fix this extra double-quoting https://github.com/AnacondaRecipes/pyside6-feedstock/pull/2/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR2, right? |
It was supposed to, but I just looked and the test regression is wrong. This must have gotten lost in the fray, I'll take another look. |
@skupr-anaconda Now we should be good. At least for the vast majority of cases. |
Fixes a number of issues around excessive quotes in JINJA statements and other support. This should significantly improve previously seen odd behavior in
crm convert
andcrm bump-recipe
.Also adds:
NodeVar
class to allow us to support tracking comments and selectors on JINJA variables. Most of this support is for V0, but there is some for V1.From the integration tests, it looks like there is a slight decline in compatibility (by maybe a few recipe files). In my investigation, it looks like the recipe files that are now failing, for the most part, already contain invalid YAML. Overall, this should be a massive improvement over the current parsing issues.