Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xdoctest #14202

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Remove xdoctest #14202

merged 1 commit into from
Sep 2, 2024

Conversation

kenodegard
Copy link
Contributor

Description

While debugging an ABI issue in conda-build's test suite we found that xdoctest hasn't actually been testing anything for us since pytest by default only crawls the tests directory and not the source code itself.

Since it hasn't been doing anything for us we might as well just remove it and evaluate adding it back in a future effort.

Xref conda/conda-build#5471

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 30, 2024
@kenodegard kenodegard marked this pull request as ready for review August 30, 2024 16:42
@kenodegard kenodegard requested a review from a team as a code owner August 30, 2024 16:42
Copy link

codspeed-hq bot commented Aug 30, 2024

CodSpeed Performance Report

Merging #14202 will not alter performance

Comparing kenodegard:remove-xdoctest (ddebd36) with main (ef93541)

Summary

✅ 21 untouched benchmarks

@jezdez jezdez merged commit 62d2364 into conda:main Sep 2, 2024
68 checks passed
jaimergp added a commit to conda/conda-libmamba-solver that referenced this pull request Sep 2, 2024
jaimergp added a commit to conda/conda-libmamba-solver that referenced this pull request Sep 3, 2024
* Remove xdoctest

Port conda/conda#14202

* add pyproject.toml to the list of CI triggers
@kenodegard kenodegard deleted the remove-xdoctest branch September 3, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants