Respect original ssl_verify values#860
Merged
jaimergp merged 4 commits intoconda:mainfrom Oct 3, 2024
Merged
Conversation
conda-bot
added
the
cla-signed
2 tasks
Contributor
Author
|
Fix confirmed at #851 (comment) |
Contributor
|
While the fix makes sense to me, is there a way you could write a test to show it? |
Contributor
Author
|
Adding tests for this turned out to be a bit tricky (would need to patch CondaSession), so instead I went for simple and added a couple of assertions in the code. What do you think? |
marcoesters
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #851
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?