Ensure local_sdist recipes use a valid URI for the source URL #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -794,7 +794,7 @@ def get_sdist_metadata( | |||
| metadata["source"] = {"url": sdist_url, "sha256": sha256_checksum(path_pkg)} | |||
| if config.from_local_sdist: | |||
| metadata["source"] = { | |||
| "url": f"file://{path_pkg}", | |||
| "url": Path(path_pkg).as_uri(), | |||
There was a problem hiding this comment.
that is indeed better, thank you!
marcelotrevisani
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #448
Hard-coded URI conversion in the pypi strategy is not valid for local sdist recipes on windows.
This uses
Path().as_uri()to convert the provided path to the sdist tarball into the proper, machine-dependent URI.