MNT: Remove 'pip install' options in recipes #584
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove --no-deps --no-build-isolation 'pip install' options in recipes as the build tool (e.g. conda-build, rattler-build) will enforce all required 'pip install' options itself at build time.
matthewfeickert
force-pushed
the
mnt/remove-pip-install-options
branch
from
cd231f2
to
d222e89
Compare
|
This is ready for review. |
|
@wolfv we can't do this while we use conda-build b/c of the multiple outputs bug. However, if/when we drop conda-build, do you know if rattler-build will behave as expected with multiple outputs? |
Out of curiosity, is there an issue for this? |
I'm pretty sure there is one, or more, in conda-build. To be fair, are trying to keep conda-build on life support as we move to rattler-build, so I don't think anyone is working on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #582
Description
--no-deps --no-build-isolationpip installoptions in recipes as the build tool (e.g.conda-build,rattler-build) will enforce all requiredpip installoptions itself at build time.c.f.: