workflow: Add actionlint workflows #2146
Conversation
stevenhorsman
force-pushed
the
actionlint
branch
4 times, most recently
from
f66c3c2
to
357009b
Compare
|
The run against my fork can be seen: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11744726638/job/32720502155, but I was hoping that the workflow would be run on this PR as well, so I'm not sure if I've made a mistake with it? |
|
Hi @stevenhorsman !
There is a typo on the |
On PRs that update anything in the workflows directory, add an actionlint run to validate our workflow files for errors and hopefully catch issues earlier. Signed-off-by: stevenhorsman <[email protected]>
Added configuration file with rules to exclude some self-hosted runners from the linter warnings. Signed-off-by: stevenhorsman <[email protected]>
> Useless cat. Consider cmd < file | .. Update to fix shellcheck issue Signed-off-by: stevenhorsman <[email protected]>
> Quote this to prevent word splitting. Quote around path Signed-off-by: stevenhorsman <[email protected]>
> input "image_tags" of workflow_call event has the default value "", but it is also required. if an input is marked as required, its default value will never be used Signed-off-by: stevenhorsman <[email protected]>
> Double quote to prevent globbing and word splitting. Signed-off-by: stevenhorsman <[email protected]>
> Use find instead of ls to better handle non-alphanumeric filenames. Signed-off-by: stevenhorsman <[email protected]>
> This loop will only ever run once. Bad quoting or missing glob/expansion? Update logic to remove the loop and simplify Signed-off-by: stevenhorsman <[email protected]>
> Double quote array expansions to avoid re-splitting elements Signed-off-by: stevenhorsman <[email protected]>
> Use $(...) notation instead of legacy backticks `...` Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
actionlint
branch
from
357009b
to
0c418c8
Compare
Awesome - thanks for the spot I knew there was something wrong - and I did do the workflow_dispatch in my fork! |
|
It's running now here: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/11819549958/job/32929721287?pr=2146. Big thank you to @wainersm! |
On PRs that update anything in the workflows directory, add an actionlint run to validate our workflow files for errors and hopefully catch issues earlier.
Also fix the many issues we already have!