Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CSV crate #562

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Bump CSV crate #562

merged 1 commit into from
Nov 13, 2024

Conversation

fitzthum
Copy link
Member

@fitzthum fitzthum commented Nov 6, 2024

With the new version of this crate I think we might not need to use the --locked flag when we built. Should we remove it?

The CSV crate has been update to not be tied to a specific
version of OpenSSL. We definitely want to pick up this change.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
@Xynnn007
Copy link
Member

Xynnn007 commented Nov 7, 2024

With the new version of this crate I think we might not need to use the --locked flag when we built. Should we remove it?

I am ok with either. If any new error we met during CI, we can go back to fix it.

@fitzthum
Copy link
Member Author

fitzthum commented Nov 7, 2024

Well the tests are fine without --locked. I've seen some mixed advice about whether --locked should be used. I lean towards removing it. We are still tracking the Cargo files so people can use --locked if they need.

@larrydewey I seem to recall that we talked about this at some point. Do you have an opinion here?

@mkulke any thoughts?

@mkulke
Copy link
Contributor

mkulke commented Nov 8, 2024

Well the tests are fine without --locked. I've seen some mixed advice about whether --locked should be used. I lean towards removing it. We are still tracking the Cargo files so people can use --locked if they need.

@larrydewey I seem to recall that we talked about this at some point. Do you have an opinion here?

@mkulke any thoughts?

afaiu --locked makes sense for release builds. otherwise there might be a different dependency resolution during the release build on the CI, that you could not reproduce easily.

@fitzthum
Copy link
Member Author

fitzthum commented Nov 8, 2024

@mkulke ok well I'll drop that commit for now and we can add it back later if needed.

@mkulke mkulke merged commit f0238eb into confidential-containers:main Nov 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants