Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe add c# namespace into the spec #518

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zetanova
Copy link

c# users of the spec need to edit it to generate the source-code to include the csharp namespace.
If the option is not allowed to be included then please remove the comment 'DO NOT EDIT'

c# users of the spec need to edit it to generate the source-code to include the csharp namespace.
If the option is not allowed to be included then please remove the comment 'DO NOT EDIT'
@nixpanic
Copy link

I think that should be fine, there is already a go_package option too.

Note that you should include this in spec.md instead, and regenerate the code (recreates csi.proto) from there.

@Zetanova
Copy link
Author

@nixpanic thx, the namespace got added to spec.md too

@jdef
Copy link
Member

jdef commented Sep 22, 2022

Thanks for the PR. Please sign the CCLA if you haven't already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants