fix: add missing --ipc options in help text and shell completion #4731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haytok
changed the title
The docs already documented `--ipc=(host|private|shareable|container:<container>)`. - https://github.com/containerd/nerdctl/blob/main/docs/command-reference.md#whale-nerdctl-run However, the implementation only had `host` and `private` in help text and completion. This adds the missing options and smart completion for `container:<name>` Signed-off-by: Hayato Kiwata <[email protected]>
haytok
force-pushed
the
fix-completion-for-ipc-option
branch
from
63d7bf4 to
09660a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs already documented
--ipc=(host|private|shareable|container:<container>).However, the implementation only had
hostandprivatein help text and completion.This adds the missing options and smart completion for
container:<name>