Skip to content

converter: fix trailing data after applying archive #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Jul 22, 2025

Read any trailing data for some tar formats, in case the PipeWriter of opposite side gets stuck.

Reference: https://github.com/containerd/containerd/blob/6373c7b53b76db25365824d3c969c409e630cf02/core/diff/apply/apply.go#L99

Read any trailing data for some tar formats, in case the
PipeWriter of opposite side gets stuck.

Reference: https://github.com/containerd/containerd/blob/6373c7b53b76db25365824d3c969c409e630cf02/core/diff/apply/apply.go#L99

Signed-off-by: imeoer <[email protected]>
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 21.37%. Comparing base (d9a8e57) to head (2e5a451).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/converter/convert_unix.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   21.38%   21.37%   -0.01%     
==========================================
  Files         122      122              
  Lines       13623    13626       +3     
==========================================
  Hits         2913     2913              
- Misses      10389    10392       +3     
  Partials      321      321              
Files with missing lines Coverage Δ
pkg/converter/convert_unix.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant