Containerd-Shim: Enabling reading annotations: make annotations public e.g., for containerd-shims#1064
Open
wlkrm wants to merge 2 commits intocontainerd:mainfrom
Open
Containerd-Shim: Enabling reading annotations: make annotations public e.g., for containerd-shims#1064wlkrm wants to merge 2 commits intocontainerd:mainfrom
wlkrm wants to merge 2 commits intocontainerd:mainfrom
Conversation
8ebf8d1 to
3d4908a
Compare
ec2f116 to
c28486e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on a containerd-shim for wasm, which uses annotations to for some container-specific configuration parameters for the runtime. For this, I need access to the annotations in my Sandbox implementation. For this I am using the cointainerd_shim_wasm.
Effectifly, I run the following containerd command:
sudo ctr run --rm --annotation --annotation 'my_config_param=example_config_value' runtime=./runwasi-shim localhost/wams-app:latest test2I would need access to the annotations in the Sandbox
run_wasimain function like this:These annotation are very specific to my usecase and are out of scope of usual oci run annotations.
To achieve that, I need access to the currently private annotations.
The PR provides an API call to access them.
EDIT: also fixes two typos in docs.