feat(otel): add context propogation from containerd to the shim #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
jprendes
previously approved these changes
Jan 30, 2025
|
|
||
| #[cfg(feature = "opentelemetry")] | ||
| tracing::Span::current().set_parent(extract_context(&ctx.metadata)); | ||
|
|
||
| Ok(self.task_create(req)?) | ||
| } | ||
|
|
||
| #[cfg_attr(feature = "tracing", tracing::instrument(parent = tracing::Span::current(), skip_all, level = "Info"))] |
There was a problem hiding this comment.
Does it need parent=.. here?
Same for the other methods.
There was a problem hiding this comment.
what do you mean by parent=...?
There was a problem hiding this comment.
The parent = tracing::Span::current() inside the tracing::instrument macro.
There was a problem hiding this comment.
okay you got a point. I will clean them up
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
jprendes
reviewed
Jan 30, 2025
Signed-off-by: Jorge Prendes <[email protected]>
this is because we made all the task_{create,...} to be Debug level instead of Info
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
jprendes
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR converts the TtrpcContext.metadata to the opentelemetry::Context and use it to propogate the parent span information to each TTRPC handler. The result of this change is that we will be able to preserve the context from containerd Task service:
This PR also marks all the utility functions as "Debug" level tracing instead of "Info". The functions that have "Info" tracing are listed below:
Module:
crates/containerd-shim-wasm/src/sandbox/cli.rsshim_main_innerModule:
crates/containerd-shim-wasm/src/sandbox/instance.rswaitModule:
crates/containerd-shim-wasm/src/sandbox/shim/cli.rsnewstart_shimwaitcreate_task_servicedelete_shimModule:
crates/containerd-shim-wasm/src/sandbox/shim/local.rscreatestartkilldeletewaitconnectstateshutdownstatsModule:
crates/containerd-shim-wasm/src/sys/unix/container/instance.rsnewstartkilldeletewait_timeout