Unmount the mount point of the container when the container is deleted. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzzzzzzzy9
force-pushed
the
umount_recursive
branch
from
1276568 to
6130801
Compare
zzzzzzzzzy9
force-pushed
the
umount_recursive
branch
from
6130801 to
c9f8dd6
Compare
zzzzzzzzzy9
force-pushed
the
umount_recursive
branch
from
c9f8dd6 to
5dc4d9a
Compare
|
I guess same suggestion here as in #305 (comment). There is a lot of linux specific stuff. Let's move those to a separate file to have less linux targets? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmount the mount point of the container when the container is deleted.
Shim will mount the rootfs on host, so when container is deleted and the shim is dead, shim should unmount the mountpoint who has been mounted by shim.