fix potential data race in nativeconverter/estargz #2133
Merged
+24
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapefreeg
force-pushed
the
data_race_fix
branch
from
3a994d2 to
07cb161
Compare
escapefreeg
force-pushed
the
data_race_fix
branch
2 times, most recently
from
f3c5ee0 to
e2c234a
Compare
escapefreeg
force-pushed
the
data_race_fix
branch
3 times, most recently
from
9a88f70 to
2548da9
Compare
Signed-off-by: clarehkli <[email protected]>
escapefreeg
force-pushed
the
data_race_fix
branch
from
2548da9 to
c3a7e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly copying the incoming
commonOptsinside bothestargzconvert.LayerConvertWithLayerAndCommonOptsFuncandesgzexternaltocconvert.LayerConvertWithLayerAndCommonOptsFuncto eliminate the data race and improve robustness and maintainability, see more at #2132