fusemanager: Log by default #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmonaco Could you add "Signed-off-by" line to the commit message? Also, please rebase on the latest main branch to fix the following CI failures: |
Done, and thanks :) |
There's `--log-level` instead. Signed-off-by: Matt Monaco <[email protected]> Signed-off-by: Matt Monaco <[email protected]>
Dropping logging output by default is surprising. I think switching this as the default is safe to do for existing users. Signed-off-by: Matt Monaco <[email protected]> Signed-off-by: Matt Monaco <[email protected]>
`os.Create()` truncates existing files already, but additionally works cleanly if the path is a literal `/dev/stdout` or `/dev/stderr` which would otherwise fail to be removed. Signed-off-by: Matt Monaco <[email protected]> Signed-off-by: Matt Monaco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fusemanager: Drop --debug flag (not used)
There's
--log-levelinstead.fusemanager: Hookup normal stdout+stderr by default
Dropping logging output by default is surprising. I think switching this as the default is safe to do for existing users.
fusemanager: Drop manual truncation of logPath
os.Create()truncates existing files already, but additionally workscleanly if the path is a literal
/dev/stdoutor/dev/stderrwhichwould otherwise fail to be removed.