build: add --source-date-epoch and --rewrite-timestamp flags #6208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/feature
Honny1
reviewed
Jun 5, 2025
|
|
||
| if options.SourceDateEpoch != nil { | ||
| if options.Timestamp != nil { | ||
| return "", nil, errors.New("timestamp and source-date-epoch would be ambiguous if allowed together") |
There was a problem hiding this comment.
This could be mentioned in the manpage.
Use $SOURCE_DATE_EPOCH as the default for the --source-date-epoch flag to the "build" CLI. When a source-date-epoch is set, we'll use it when writing new history entries, force timestamps in data written for --output to the specified timestamp, and populate a "SOURCE_DATE_EPOCH" ARG that we treat as always being set, and which we don't complain about being left unused. By default, this will not affect timestamps in newly-added layers. Add a --rewrite-timestamp flag, which "clamps" timestamps in newly-added layers to not be later than the --source-date-epoch value if the --source-date-epoch flag is set, but has no effect otherwise. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
build-source-date-epoch
branch
from
fd8a8e8 to
865dace
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use $SOURCE_DATE_EPOCH as the default for the
--source-date-epochflag to the "build" CLI.When a source-date-epoch is set, we'll use it when writing new history entries, force timestamps in data written for
--outputto the specified timestamp, and populate a "SOURCE_DATE_EPOCH" ARG that we treat as always being set, and which we don't complain about being left unused. By default, this will not affect timestamps in newly-added layers.Add a
--rewrite-timestampflag, which "clamps" timestamps in newly-added layers to not be later than the--source-date-epochvalue if the--source-date-epochflag is set, but has no effect otherwise.Fix a bug in the
dir_image_last_diff()helper function introduced in a57e7f4 as part of #6178.How to verify it
New integration tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?