Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CONTRIBUTING.md #2207

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 18, 2024

Change the DCO wording so that it is clear that we do not need the real
name, just someting the properly identifies that person within the
community.

Touch up the old Reporting Issues and Submitting Pull Requests section
based on Matt's work in podman[1] and add some extra step in there.

Add new sections for the vendor process and and how to use git bisect.

[1] containers/podman#24261

Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Freenode is dead for a long time, link to our website which has all the
chat links.

Signed-off-by: Paul Holzinger <[email protected]>
Change the DCO wording so that it is clear that we do not need the real
name, just someting the properly identifies that person within the
community.

Touch up the old Reporting Issues and Submitting Pull Requests section
based on Matt's work in podman[1] and add some extra step in there.

Add new sections for
 - code review
 - rebasing
 - vendor process
 - git bisect

[1] containers/podman#24261

Signed-off-by: Paul Holzinger <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Oct 21, 2024

LGTM

@Luap99
Copy link
Member Author

Luap99 commented Oct 21, 2024

@mheon @baude PTAL

@mheon
Copy link
Member

mheon commented Oct 21, 2024

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 780dc20 into containers:main Oct 21, 2024
16 checks passed
@Luap99 Luap99 deleted the contributing branch October 22, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants