update CONTRIBUTING.md #2207
Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom Oct 21, 2024
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Freenode is dead for a long time, link to our website which has all the chat links. Signed-off-by: Paul Holzinger <[email protected]>
Change the DCO wording so that it is clear that we do not need the real name, just someting the properly identifies that person within the community. Touch up the old Reporting Issues and Submitting Pull Requests section based on Matt's work in podman[1] and add some extra step in there. Add new sections for - code review - rebasing - vendor process - git bisect [1] containers/podman#24261 Signed-off-by: Paul Holzinger <[email protected]>
Member
|
LGTM |
Member
Author
Member
|
LGTM |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the DCO wording so that it is clear that we do not need the real
name, just someting the properly identifies that person within the
community.
Touch up the old Reporting Issues and Submitting Pull Requests section
based on Matt's work in podman[1] and add some extra step in there.
Add new sections for the vendor process and and how to use git bisect.
[1] containers/podman#24261