Revert "Disable criu support on riscv64"#1730
Merged
giuseppe merged 1 commit intocontainers:mainfrom Apr 30, 2025
Merged
Conversation
Reviewer's GuideThis pull request reverts a previous commit by removing the conditional logic in File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @KristinaHa26 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lsm5
requested changes
Apr 30, 2025
Member
lsm5
left a comment
There was a problem hiding this comment.
commit needs signoff. LGTM otherwise. Thanks!
This reverts commit 4ea62f2. Signed-off-by: Kristina Hanicova <[email protected]>
Author
|
fixed, thank you! |
|
TMT tests failed. @containers/packit-build please check. |
Member
|
The centos-stream-9 failure might be a flake. Rerunning it. But I guess we'd be safe to merge either way as it's unrelated to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4ea62f2.
The support for riscv64 in criu was merged recently: https://src.fedoraproject.org/rpms/criu/pull-request/14#
so we can remove this.
Thanks in advance for your consideration!
Summary by Sourcery
Chores: