-
Notifications
You must be signed in to change notification settings - Fork 344
Revert "Disable criu support on riscv64" #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request reverts a previous commit by removing the conditional logic in File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KristinaHa26 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit needs signoff. LGTM otherwise. Thanks!
This reverts commit 4ea62f2. Signed-off-by: Kristina Hanicova <[email protected]>
fixed, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your patch!
LGTM
TMT tests failed. @containers/packit-build please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The centos-stream-9 failure might be a flake. Rerunning it. But I guess we'd be safe to merge either way as it's unrelated to the PR. |
This reverts commit 4ea62f2.
The support for riscv64 in criu was merged recently: https://src.fedoraproject.org/rpms/criu/pull-request/14#
so we can remove this.
Thanks in advance for your consideration!
Summary by Sourcery
Chores: