Skip to content

Packit: Disable osh_diff_scan #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Packit: Disable osh_diff_scan #1731

merged 1 commit into from
Apr 30, 2025

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Apr 30, 2025 •
edited by sourcery-ai bot
Loading

The differential scans run by Packit currently report false positives.

Fixes: #1729

Summary by Sourcery

Chores:

  • Disabled osh_diff_scan in Packit configuration to address false positive scanning issues

Summary by Sourcery

Chores:

  • Disabled osh_diff_scan after Copr build to prevent false positive reports

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Apr 30, 2025 •
edited
Loading

Reviewer's Guide

This pull request disables the osh_diff_scan_after_copr_build setting in the .packit.yaml file by setting its value to false within the copr_build job configuration, addressing reported false positives in differential scans.

File-Level Changes

Change Details Files
Disabled differential scan after Copr build in Packit configuration.
  • Set osh_diff_scan_after_copr_build to false.
  • Added a comment linking to the GitHub issue explaining the reason.
 .packit.yaml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

giuseppe
giuseppe approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5
Packit: Disable osh_diff_scan
dd8e1af 
The differential scans run by Packit currently report false positives.

Fixes: containers#1729

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the osh-diff-scan-disable branch from 4df3d2a to dd8e1af Compare April 30, 2025 12:58
@lsm5 lsm5 marked this pull request as ready for review April 30, 2025 13:04
sourcery-ai[bot]
sourcery-ai bot approved these changes Apr 30, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lsm5 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@packit-as-a-service Packit-as-a-Service
Copy link

TMT tests failed. @containers/packit-build please check.

flouthoc
flouthoc approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc flouthoc merged commit 1cdec79 into containers:main Apr 30, 2025
47 checks passed
lsm5 added a commit to lsm5/crun that referenced this pull request May 1, 2025
@lsm5
Revert "Packit: Disable osh_diff_scan"
39dace9 
After checking further with Siteshwar, disabling this job in containers#1731
was a rather hasty decision. The Packit osh diff scan job hasn't caused any
actual noise upstream because of false positives and on the contrary
has found out actual issues.
Refs:
[0] containers#1708 (comment)
[1] containers#1689 (comment)
[2] containers#1695 (comment)

A false positive result in a Packit osh diff scan would pass with a
warning sign:
Ref: https://github.com/stratis-storage/stratisd/pull/3811/checks?check_run_id=41436634933

So not really any annoyance upstream.

Siteshwar will disable crun in the mass scans, so that should suffice.

This reverts commit dd8e1af.
@lsm5 lsm5 mentioned this pull request May 1, 2025
Merged
lsm5 added a commit to lsm5/crun that referenced this pull request May 1, 2025
@lsm5
Revert "Packit: Disable osh_diff_scan"
19b4c25 
After checking further with Siteshwar, disabling this job in containers#1731
was a rather hasty decision. The Packit osh diff scan job hasn't caused any
actual noise upstream because of false positives and on the contrary
has found out actual issues.
Refs:
[0] containers#1708 (comment)
[1] containers#1689 (comment)
[2] containers#1695 (comment)

A false positive result in a Packit osh diff scan would pass with a
warning sign:
Ref: https://github.com/stratis-storage/stratisd/pull/3811/checks?check_run_id=41436634933

So not really any annoyance upstream.

Siteshwar will disable crun in the mass scans, so that should suffice.

This reverts commit dd8e1af.

Signed-off-by: Lokesh Mandvekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@flouthoc flouthoc flouthoc approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Findings by static analyzers in Fedora 43
3 participants
@lsm5 @giuseppe @flouthoc