[v5.3] Bump to Buildah v1.38.0 #24528
Conversation
TomSweeneyRedHat
added
the
No New Tests
openshift-ci
bot
added
release-note-none
approved
|
Crossing my fingers on this. The make died in the docs directory in my sandbox, but I think it's an issue in my troff settings in my newly updated VM. |
|
Culprit seems to be containers/common#2174 |
|
Oh I missed that we have such a test here. Line 1037 in 15b45c5 It is clearly not sane to create such a import file in a e2e tests without user consent. And more importantly it will affected all parallel running tests. Given the new logic requires the kernel to be booted in the right mode (I think?!) we have no way of chaining this thus I recommend nuking the test or skip it always for now |
|
Also you need to pick #24526 as Ed mentioned during standup. |
* treadmill script: handle an obscure corner case wherein the script would bail because it thought there were no buildah-vendor changes. * two new test skips * update the diffs; line-number changes due to buildah PRs touching helpers.bash Signed-off-by: Ed Santiago <[email protected]> (cherry picked from commit 33398eb) Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/buildahv1.38
branch
from
15b45c5
to
620a111
Compare
|
Thanks @Luap99 , I've cherry-picked @edsantiago 's commit, and repushed. Fingers double crossed now. |
|
Without removing/skipping the FPIS int test this will not pass, #24528 (comment) |
|
Missed the FIPS bit @Luap99 , I assumed (oh, oh), that was part of the cherry-pick that you pointed at. WIll touch that up too. |
The FIPS mode secrets test cannot run on this branch, skip them for now. Signed-off-by: tomsweeneyredhat <[email protected]>
Bump to Buildah v1.38.0 in preparation of Podman v5.3. This will also ensure the following versions are in place: c/storage: v1.56.0 c/image: v5.33.0 c/common: v0.61.0 Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/buildahv1.38
branch
from
620a111
to
31df1bb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM2 |
|
/lgtm |
openshift-merge-bot
bot
merged commit 4002405
into
containers:v5.3
Bump to Buildah v1.38.0 in preparation of Podman v5.3.
This will also ensure the following versions are in place:
c/storage: v1.56.0
c/image: v5.33.0
c/common: v0.61.0
Does this PR introduce a user-facing change?