Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay mounts supersede image volumes & volumes-from #24565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Overlay mounts supersede image volumes & volumes-from #24565

wants to merge 1 commit into from

Commits on Nov 15, 2024

  1. Overlay mounts supersede image volumes & volumes-from 

    This matches the behavior of other volume and mount types. Image
volumes and volumes/mounts from the `--volumes-from` flag should
be overridden by actual user-specified named volumes and mounts,
but this was not true for overlay mounts. Fortunately, our
duplicate-mount detection logic still works, so we got a good
error message at least.

The fix is simple - extend our supersede logic, which currently
only works with named volumes and mounts, to also work with
overlay mounts.

Fixes containers#24555

Signed-off-by: Matt Heon <[email protected]>
    @mheon
    mheon committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    61b57b7 View commit details
    Browse the repository at this point in the history