Skip to content

Adding c10s repo #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Adding c10s repo #837

wants to merge 2 commits into from

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Jun 3, 2025

resolve #828

Fixing .packit.yaml indenentations

Summary by Sourcery

Correct YAML formatting in .packit.yaml, standardize repository anchors, and update test matrix targets

Enhancements:

  • Rename &bluechi_copr_repo anchor to &bluechi_copr_repo_c9s and reference it consistently in environments
  • Add centos-stream-9 copr repository-file anchor alongside existing Fedora repo
  • Update the Fedora test target from fedora-41 to fedora-42 in the kvm-tier-0 plan
  • Fix YAML indentation for artifacts, hardware.disk entries, and tmt.scenario key

@Yarboa Yarboa self-assigned this Jun 3, 2025
Copy link
Contributor

sourcery-ai bot commented Jun 3, 2025

Reviewer's Guide

This PR refactors the .packit.yaml configuration by renaming a repository anchor, updating artifact references, correcting YAML indentations for list and mapping items, and bumping the Fedora target from 41 to 42 in the kvm-tier-0 job.

File-Level Changes

Change Details Files
Renamed repository anchor and updated its references in artifacts.
  • Changed anchor name from &bluechi_copr_repo to &bluechi_copr_repo_c9s
  • Replaced all usages of *bluechi_copr_repo with *bluechi_copr_repo_c9s
.packit.yaml
Corrected YAML indentation for list and mapping structures.
  • Aligned list items under hardware.disk with correct indentation
  • Fixed mapping indentation for scenario and virtualization keys
.packit.yaml
Added combined artifact anchors in kvm-tier-0 job.
  • Included both *bluechi_copr_repo_c9s and *bluechi_copr_repo_fedora under artifacts
.packit.yaml
Updated Fedora target version in kvm-tier-0 job.
  • Replaced fedora-41 with fedora-42 in the targets list
.packit.yaml

Assessment against linked issues

Issue Objective Addressed Explanation
#828 Add CentOS 10 tests to the CI/CD pipeline. The PR modifies .packit.yaml by changing centos-stream-9 to centos-stream-9 and fixing indentation, but it doesn't add any specific configuration or tests for CentOS 10. The issue requests adding CentOS 10 tests, which this PR does not do.
#828 Ensure the QM build for CentOS 10 is tested in the CI/CD. The PR does not introduce any changes that would specifically test the QM build for CentOS 10. It only modifies existing configurations related to other CentOS versions.
#828 Incorporate the CentOS 10 package from the testing repository into the CI/CD tests. The PR doesn't add any specific steps or configurations to include the CentOS 10 package from the testing repository into the CI/CD tests. The changes are limited to indentation fixes and modifications related to existing CentOS versions.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

resolve containers#828

Fixing .packit.yaml indenentations

Signed-off-by: Yariv Rachmani <[email protected]>
LOCK_DISK_SPACE could be configured for c10s
Takes more then 10m to finish
Adding c10 condition to execute set-ffi-env-e2e
script for creating diskpartition

Signed-off-by: Yariv Rachmani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS 10: Add into the CI/CD tests
1 participant