Skip to content

Test: Change to centirepos #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

swadeley
Copy link
Member

@swadeley swadeley commented Apr 9, 2025

Summary

I made a new batch of 100 repos without a number in the URL
The multirepos path with a rank number in URL causes problems when that number corresponds to a release version.

Testing steps

tests pass

@swadeley swadeley self-assigned this Apr 9, 2025
@swadeley swadeley force-pushed the swadeley/change_to_centirepos branch from 7b49a1b to b38f890 Compare April 9, 2025 14:33
@rverdile
Copy link
Contributor

looks good but there's a linting issue

@rverdile
Copy link
Contributor

rverdile commented Apr 10, 2025

Doesn't break anything, but wanted to point out that some the repos are named with a leading 0 e.g. repo03. I'm not sure if you meant to include those.

@rverdile
Copy link
Contributor

Oh and there's no repo1, so I think that would be an issue if the randomURL function returned repo1

without number in URL
@swadeley swadeley force-pushed the swadeley/change_to_centirepos branch from b38f890 to 4f3fa7f Compare April 14, 2025 15:49
@swadeley
Copy link
Member Author

Oh and there's no repo1, so I think that would be an issue if the randomURL function returned repo1

I think that code is OK, grok says:
randomNum: Exports a string representing numbers from 1 to 100, padded as "01" to "100".

@swadeley
Copy link
Member Author

Doesn't break anything, but wanted to point out that some the repos are named with a leading 0 e.g. repo03. I'm not sure if you meant to include those.

Hi, yes, I prefer to use leading zeros so that where the repo numbers are used in the names it helps with sorting sorting (looks better, easier to read, in pagination tests). I have now deleted repos 2 to 9 without leading zeros which were created by mistake.

Thank you

@rverdile rverdile changed the title Change to centirepos Test: Change to centirepos Apr 14, 2025
@swadeley
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants