Skip to content

Refs 4133: add types filter to admin tasks list #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

rverdile
Copy link
Contributor

Summary

Adds ability to filter admin tasks by type

Testing steps

  1. Either test using frontend PR or make a request like GET /admin/tasks/?type=introspect,snapshot
  2. Make sure you've created/deleted some repos and templates so you have a few task types to filter.
  3. These are all the task types: https://github.com/content-services/content-sources-backend/blob/main/pkg/config/tasks.go#L4-L9

Checklist

  • Tested with snapshotting feature disabled and pulp server URL not configured if appropriate

@jlsherrill
Copy link
Member

@jlsherrill
Copy link
Member

⚠️ This task currently requires qe-approval, but this PR does not fully resolve the task. Please contact QE to determine appropriate testing required.

Copy link
Contributor

@xbhouse xbhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with API and frontend PR, looks great!

@swadeley
Copy link
Member

Works great, thank you

content-services/content-sources-frontend#285 (comment)

@swadeley swadeley merged commit 33cd4f1 into content-services:main Jun 19, 2024
@rverdile rverdile deleted the filter-task-type branch June 24, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants