-
Notifications
You must be signed in to change notification settings - Fork 30
Build: add a PW testing style guide #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: add a PW testing style guide #507
Conversation
0af8ee9
to
99c6d6b
Compare
Reviewer's GuideThis PR adds a comprehensive Markdown-based Playwright testing style guide under File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dominikvagner - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dominikvagner - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add one more good practice - don't use sleep. If you need to wait for something, define it same way as user would wait for it. Sleeps make tests flaky and/or slow.
b3d7ab4
to
dfc4586
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
dfc4586
to
117ce8e
Compare
Summary
This adds a style guide for writing Playwright tests. 💅🏼