Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [GROOT-1550] add support for taxonomy PUT methods #2464

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LiamStokingerContentful
Copy link

Summary

This PR introduces new createWithId methods for upcoming taxonomy PUT endpoints on concepts and concept schemes

Description

This extends current concept and conceptScheme entities with createWithId methods, which will expose access to new PUT endpoints

Motivation and Context

Users want to be able to create taxonomies from external systems and link them easily with a shared ID. Currently with our POST methods, we generate a base 62 converted UUID as the sole ID for a concept or concept scheme.

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

Copy link
Member

@maxcheremisin maxcheremisin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants