Add lcd display emulation for dot-matrix-lcd with pt6520 controllers #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay controllers Add a sample node code to demonstrate usage of display emulation classes.
|
Looks like it works fine! But is there any general interest? I do not have any Contiki port to test build other firmwares, etc so for me it is hard to make use of it other than running the firmware included in the PR. Any other comments? |
|
Although I have no use case and the code could use some re-factoring I think this is to cool to be rejected. |
|
Well then - that is some general interest then ;-) I'll take a quick look at the code - I think that is ok to get it in - it just add more emulation and does not change anything that might break anything else from what I can see. |
nfi
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lcd display emulation for electronic assembly 122dip and pt6520 display controllers
Add a sample node code to demonstrate usage of display emulation classes.