fix(cli): show create new assistant option when logged in#11004
Open
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
Open
fix(cli): show create new assistant option when logged in#11004uinstinct wants to merge 1 commit intocontinuedev:mainfrom
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/ui/ConfigSelector.tsx">
<violation number="1" location="extensions/cli/src/ui/ConfigSelector.tsx:115">
P2: Conditioning the create option on authentication can leave ConfigSelector with zero options for logged-out first-time users, producing a dead-end selector state with invalid navigation indexes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| displaySuffix: " (opens web)", | ||
| }); | ||
| // Add "Create new assistant" option only when logged in | ||
| if (accessToken) { |
Contributor
There was a problem hiding this comment.
P2: Conditioning the create option on authentication can leave ConfigSelector with zero options for logged-out first-time users, producing a dead-end selector state with invalid navigation indexes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/cli/src/ui/ConfigSelector.tsx, line 115:
<comment>Conditioning the create option on authentication can leave ConfigSelector with zero options for logged-out first-time users, producing a dead-end selector state with invalid navigation indexes.</comment>
<file context>
@@ -111,13 +111,15 @@ const ConfigSelector: React.FC<ConfigSelectorProps> = ({
- displaySuffix: " (opens web)",
- });
+ // Add "Create new assistant" option only when logged in
+ if (accessToken) {
+ options.push({
+ id: "create",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"Create new assistant option (opens web)" should be only shown when the user is logged in.
Eventually, another option should be added to create a config locally (and shown in the config list).
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Only show "Create new assistant (opens web)" in the CLI config selector when the user is logged in. The option is now gated on accessToken presence to avoid showing unusable actions to unauthenticated users.
Written for commit ec638b0. Summary will update on new commits.
Continue Tasks: 🔄 7 running — View all