Skip to content

fix(cli): show create new assistant option when logged in#11004

Open
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
uinstinct:cli-new-assistant-option
Open

fix(cli): show create new assistant option when logged in#11004
uinstinct wants to merge 1 commit intocontinuedev:mainfrom
uinstinct:cli-new-assistant-option

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Mar 3, 2026

Description

"Create new assistant option (opens web)" should be only shown when the user is logged in.

Eventually, another option should be added to create a config locally (and shown in the config list).

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Only show "Create new assistant (opens web)" in the CLI config selector when the user is logged in. The option is now gated on accessToken presence to avoid showing unusable actions to unauthenticated users.

Written for commit ec638b0. Summary will update on new commits.


Continue Tasks: 🔄 7 running — View all

@uinstinct uinstinct marked this pull request as ready for review March 3, 2026 12:34
@uinstinct uinstinct requested a review from a team as a code owner March 3, 2026 12:34
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team March 3, 2026 12:34
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 3, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="extensions/cli/src/ui/ConfigSelector.tsx">

<violation number="1" location="extensions/cli/src/ui/ConfigSelector.tsx:115">
P2: Conditioning the create option on authentication can leave ConfigSelector with zero options for logged-out first-time users, producing a dead-end selector state with invalid navigation indexes.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

displaySuffix: " (opens web)",
});
// Add "Create new assistant" option only when logged in
if (accessToken) {
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Conditioning the create option on authentication can leave ConfigSelector with zero options for logged-out first-time users, producing a dead-end selector state with invalid navigation indexes.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/cli/src/ui/ConfigSelector.tsx, line 115:

<comment>Conditioning the create option on authentication can leave ConfigSelector with zero options for logged-out first-time users, producing a dead-end selector state with invalid navigation indexes.</comment>

<file context>
@@ -111,13 +111,15 @@ const ConfigSelector: React.FC<ConfigSelectorProps> = ({
-          displaySuffix: " (opens web)",
-        });
+        // Add "Create new assistant" option only when logged in
+        if (accessToken) {
+          options.push({
+            id: "create",
</file context>
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant