Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jetbrains config error support + config fixes #3794

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add jetbrains config error support + config fixes #3794

wants to merge 3 commits into from

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jan 21, 2025 •
edited
Loading

Description

  • Remove configError message entirely since is now duplicate of configUpdate with ConfigResult
  • Don't unnecessarily reload config in core's onConfigUpdate handler, just convert it to serialized config
  • Remove duplicate sending of config and errors from VsCodeExtension
  • Always select default model before using default title, so that will never send invalid title

@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 756288a
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/678f3f64c5a729000993941b

@RomneyDa RomneyDa mentioned this pull request Jan 23, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RomneyDa