Minor polishing #14
Merged
Minor polishing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Parpart <[email protected]>
Signed-off-by: Christian Parpart <[email protected]>
Signed-off-by: Christian Parpart <[email protected]>
Yaraslaut
requested changes
Dec 11, 2023
There was a problem hiding this comment.
I corrected formatting
editorconfig still does not like things, not sure why
also, ubuntu ships only with catch2 (2.13.8-1) see: https://packages.ubuntu.com/jammy/catch2 so we can not build with v3 inside actions,
I think that we should not enable testing by default so if you include boxed in your project there is not catch dependency to build it
sounds good to me |
christianparpart
force-pushed
the
minor-polishing
branch
5 times, most recently
from
81cb86e to
411e5cd
Compare
Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
minor-polishing
branch
3 times, most recently
from
c2a29e0 to
0c70212
Compare
Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
minor-polishing
branch
from
0c70212 to
d3711e8
Compare
Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
minor-polishing
branch
2 times, most recently
from
5a7cfe6 to
2e1f3d3
Compare
Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
minor-polishing
branch
from
2e1f3d3 to
6185e52
Compare
Yaraslaut
force-pushed
the
minor-polishing
branch
7 times, most recently
from
5c69698 to
2cfd1cf
Compare
Yaraslaut
force-pushed
the
minor-polishing
branch
3 times, most recently
from
d1ceb7b to
6185e52
Compare
christianparpart
force-pushed
the
minor-polishing
branch
8 times, most recently
from
739571f to
7327ee6
Compare
…s/runner-images#8659 get fixed Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
minor-polishing
branch
from
7327ee6 to
e4af94b
Compare
Yaraslaut
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually did it because i believed we do not have an install target, but
cmake --build ... --target installdoes in fact install.So I ended up polishing a bit.
Question: I hard-depend on Catch2 version 3 now, in case we build with tests. Would this interfere with Contour, when depending on it? (I'm primarily concerned for the Ubuntu 18 builds, but there we provide it from within Contour...) 🤔