Implement function to get value from environemt via `$` or `${}` #19

Yaraslaut · 2023-12-22T10:51:58Z

Closes #10

src/shell/Lexer_test.cpp

src/shell/Shell_test.cpp

christianparpart

some comments on naming only, I think (for now).
I'd like to think about the parsing later (with a little bit more time), also with string interpolation in mind (which is still missing)

src/shell/ASTPrinter.cpp

src/shell/Shell.cpp

src/shell/IRGenerator.cpp

christianparpart · 2024-01-20T21:06:08Z

@Yaraslaut FYI, I did git rebase to resolve the merge conflicts.

christianparpart reviewed Dec 22, 2023

View reviewed changes

src/shell/Lexer_test.cpp Show resolved Hide resolved

christianparpart reviewed Dec 22, 2023

View reviewed changes

src/shell/Shell_test.cpp Outdated Show resolved Hide resolved

christianparpart reviewed Dec 22, 2023

View reviewed changes

src/shell/Shell_test.cpp Outdated Show resolved Hide resolved

christianparpart reviewed Dec 22, 2023

View reviewed changes

src/shell/ASTPrinter.cpp Outdated Show resolved Hide resolved

src/shell/Shell.cpp Outdated Show resolved Hide resolved

src/shell/IRGenerator.cpp Outdated Show resolved Hide resolved

Yaraslaut added 4 commits January 20, 2024 22:03

Implement function to get value from environemt via $ or ${}

3fcc912

Rename and update tests

5eb9645

Rename to getenv

bbb51b7

IR generation

ad3bf90

christianparpart force-pushed the improvement/implement_get branch from 8f1eb23 to ad3bf90 Compare January 20, 2024 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement function to get value from environemt via `$` or `${}` #19

Implement function to get value from environemt via `$` or `${}` #19

Yaraslaut commented Dec 22, 2023

christianparpart left a comment

christianparpart commented Jan 20, 2024

Implement function to get value from environemt via $ or ${} #19

Are you sure you want to change the base?

Implement function to get value from environemt via $ or ${} #19

Conversation

Yaraslaut commented Dec 22, 2023

christianparpart left a comment

Choose a reason for hiding this comment

christianparpart commented Jan 20, 2024

Implement function to get value from environemt via `$` or `${}` #19

Implement function to get value from environemt via `$` or `${}` #19