Add tests and concepts for some functions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -751,6 +752,7 @@ constexpr ResultType FoldMembers(ResultType initialValue, Callable const& callab | |||
| /// | |||
| /// @return The result of the fold | |||
| template <typename Object, typename Callable, typename ResultType> | |||
| requires std::same_as<ResultType, std::invoke_result_t<Callable, std::string, MemberTypeOf<1, Object>, ResultType>> | |||
There was a problem hiding this comment.
why std::string as first parameter? Shouldn't that be ResultType?
There was a problem hiding this comment.
callable is called in the following way:
result = callable(MemberNameOf<I, Object>, value, result);
so it must take MemberNameOf<I, Object> (std::string) as first argument and return result type which is ResultType
In the requires statement we first check that we can invoke callable with the required arguments
std::invoke_result_t<Callable, std::string, MemberTypeOf<1, Object>, ResultType>
and then check that returned type is ResultType in std::same_as<ResultType, std::invoke_result_t<>>
| @@ -715,6 +715,7 @@ constexpr void EnumerateMembers(Callable&& callable) | |||
| } | |||
|
|
|||
| template <typename Object, typename Callable> | |||
| requires std::same_as<void, std::invoke_result_t<Callable, std::string, MemberTypeOf<1, Object>>> | |||
There was a problem hiding this comment.
same question here as I asked below (sorry) :-)
Yaraslaut
force-pushed
the
improvement/tests_and_concepts_for_callable
branch
from
b6e6ba3 to
665a4b5
Compare
christianparpart
approved these changes
Nov 12, 2024
christianparpart
deleted the
improvement/tests_and_concepts_for_callable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test and requires for provided functions