Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem of working on structs with only a single element #16

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

christianparpart
Copy link
Member

in Lightweight I noticed, that we cannot work on single-value structs. Hence, this fix here (or workaround? Well, at least it's working) :)

Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment regarding constrains on the types that can be used with the library

@christianparpart christianparpart force-pushed the fix/single-value-structs branch 2 times, most recently from 91f2d18 to 19788a1 Compare December 11, 2024 20:55
@christianparpart christianparpart marked this pull request as draft December 11, 2024 21:04
@christianparpart
Copy link
Member Author

@Yaraslaut i've been rewriting CountMembers<T> for good, actually. But this is not working around the problem on GCC on CI.

For Lightweight I don't care too much, because on Fedora (Clang/GCC) it compiles as well as MSVC (VS 2022) compiles perfectly, but I'm afraid we might need some older compilers for Contour. Do you have an idea on how to catch the root cause here, or how to work around it?

@Yaraslaut Yaraslaut force-pushed the fix/single-value-structs branch from fb3242c to 9186051 Compare December 12, 2024 10:41
@Yaraslaut Yaraslaut marked this pull request as ready for review December 12, 2024 10:43
@Yaraslaut Yaraslaut merged commit 6fdb93f into master Dec 12, 2024
5 checks passed
@christianparpart christianparpart deleted the fix/single-value-structs branch January 21, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants