-
Notifications
You must be signed in to change notification settings - Fork 235
Add optional FAKTORY_WEBUI_PASSWORD
with argon2id, bcrypt, scrypt, and PBKDF2 support
#511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Looks like some CI failures? |
Code looks great and nice PR writeup. Well done. |
@@ -4,17 +4,17 @@ go 1.24 | |||
|
|||
require ( | |||
github.com/BurntSushi/toml v1.5.0 | |||
github.com/contribsys/faktory_worker_go v1.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mperham FYI looks like this module isn't used anymore and tidy
dropped it.
@mperham should be good for another CI run and ready for merge at your convenience. Needed a |
I'm not a fan of creating a new |
Makes sense to me. Once I did that, I had a random memory usage test fail in |
Closes #510
New functionality:
FAKTORY_WEBUI_PASSWORD
can be specified. If set, it will configure the Web UI with that password otherwise will fallback toFAKTORY_PASSWORD
value. This is the existing behaviour for the undocumented TOML config[web]
subsystem'spassword
element.Rationale:
/etc/shadow
after all these years. It's considered the de facto standard for representing password hashes in a non-standardized world of password hashing. It's what's used by Argon2 and the likes. Popular hashing libraries like Python's passlib use it and should come as no surprise to developers using Faktory.golang.org/x/crypto
module, so we can trust the implementations are cryptographically correct.Interface:
There is a new
password
module withfunc Verify(candidate string, configured string) (bool, error)
. This is what will allow detection of password hashing algos and match accordingly (or fallback to plaintext).