Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename package to gplibrary to match repo name #170

Open
bqpd opened this issue May 2, 2018 · 4 comments
Open

rename package to gplibrary to match repo name #170

bqpd opened this issue May 2, 2018 · 4 comments

Comments

@bqpd
Copy link
Contributor

bqpd commented May 2, 2018

per convexengineering/solar@07d17d3#commitcomment-28826411
bqpd referenced this issue in convexengineering/solar May 2, 2018
@1ozturkbe
Update gpkitmodels to gplibrary
07d17d3 
I was trying to install the model to figure out how to use Sankey, when I ran into this error
```python
$ pip install -e solar
Obtaining file:///C:/Users/Berk/Dropbox%20%28MIT%29/MIT%20Graduate%20School/code/solar
Requirement already satisfied: numpy in c:\users\berk\anaconda2\lib\site-packages (from solar==0.0.0.0) (1.14.2)
Requirement already satisfied: scipy in c:\users\berk\anaconda2\lib\site-packages (from solar==0.0.0.0) (0.19.0)
Requirement already satisfied: gpkit in c:\users\berk\dropbox (mit)\mit graduate school\code\gpkit (from solar==0.0.0.0) (0.7.0.0)
Requirement already satisfied: pandas in c:\users\berk\anaconda2\lib\site-packages (from solar==0.0.0.0) (0.17.1)
Requirement already satisfied: gpfit in c:\users\berk\dropbox (mit)\mit graduate school\code\gpfit (from solar==0.0.0.0) (0.1)
Collecting gpkitmodels (from solar==0.0.0.0)
  Could not find a version that satisfies the requirement gpkitmodels (from solar==0.0.0.0) (from versions: )
No matching distribution found for gpkitmodels (from solar==0.0.0.0)
```
This is because the module is no longer called gpkitmodels. Easy fix.
@1ozturkbe
Copy link
Contributor

@bqpd I have created the branch libRename and changed all mentions of gpkitmodels to gplibrary, since it was really easy. This might make people upset though when their models start throwing errors. How does one deal with that?

@1ozturkbe
Copy link
Contributor

@bqpd are we planning to implement this at any point, perhaps with a deprecation warning? It seems like low hanging fruit.

@1ozturkbe
Copy link
Contributor

This also has to do with issue #142

@bqpd
Copy link
Contributor Author

bqpd commented Jun 26, 2019

Let's do it! unfortunately there's not quite room for a deprecation warning. I think the following steps should do:

  • change each repo's references to gpkitmodels to a reference to gplibrary
  • update the Jenkins scripts
  • run repo tests / model tests / etc. to make sure they run on jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bqpd @1ozturkbe