Skip to content

Commit

Permalink
Update gpkitmodels to gplibrary
Browse files Browse the repository at this point in the history
I was trying to install the model to figure out how to use Sankey, when I ran into this error
```python
$ pip install -e solar
Obtaining file:///C:/Users/Berk/Dropbox%20%28MIT%29/MIT%20Graduate%20School/code/solar
Requirement already satisfied: numpy in c:\users\berk\anaconda2\lib\site-packages (from solar==0.0.0.0) (1.14.2)
Requirement already satisfied: scipy in c:\users\berk\anaconda2\lib\site-packages (from solar==0.0.0.0) (0.19.0)
Requirement already satisfied: gpkit in c:\users\berk\dropbox (mit)\mit graduate school\code\gpkit (from solar==0.0.0.0) (0.7.0.0)
Requirement already satisfied: pandas in c:\users\berk\anaconda2\lib\site-packages (from solar==0.0.0.0) (0.17.1)
Requirement already satisfied: gpfit in c:\users\berk\dropbox (mit)\mit graduate school\code\gpfit (from solar==0.0.0.0) (0.1)
Collecting gpkitmodels (from solar==0.0.0.0)
  Could not find a version that satisfies the requirement gpkitmodels (from solar==0.0.0.0) (from versions: )
No matching distribution found for gpkitmodels (from solar==0.0.0.0)
```
This is because the module is no longer called gpkitmodels. Easy fix.
  • Loading branch information
1ozturkbe authored May 2, 2018
1 parent 7eef17a commit 07d17d3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
author="MIT Convex Engineering",
author_email="[email protected]",
url="https://www.github.com/convexengineering/solar",
install_requires=["numpy", "scipy", "gpkit", "pandas", "gpfit", "gpkitmodels"],
install_requires=["numpy", "scipy", "gpkit", "pandas", "gpfit", "gplibrary"],
version="0.0.0.0",
packages=["solar"],
package_data={"solar": ["*.csv"]},
Expand Down

4 comments on commit 07d17d3

@1ozturkbe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darnit, never mind, it's gplibrary at the top level but the requirement is still called gpkitmodels. @mjburton11 @bqpd we should probably change this?

@bqpd
Copy link
Contributor

@bqpd bqpd commented on 07d17d3 May 2, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ozturkbe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has!

@bqpd
Copy link
Contributor

@bqpd bqpd commented on 07d17d3 May 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! made an issue: convexengineering/gplibrary#170

Please sign in to comment.