-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bootstrap dark mode #5629
Comments
Sure, why not. I don't think it's worth the complexity of adding it as a template option and agree that "we should just add this" 👍🏻 |
Great
heres a screenshot where i'm using bootstrap icons and the bundled version |
I wonder if we should store the user's theme preference (light/dark) in the session and pass it to the template on all page loads. This would let us set the correct theme immediately rather than relying on JS to change it after the page loads. I'm speculating and need to confirm my assumption is correct |
Description
Bootstrap 5.3 now supports a dark mode out of the box
https://getbootstrap.com/docs/5.3/customize/color-modes/#dark-mode
in the docs they provide example js that can be used to toggle btw light and dark mode: https://getbootstrap.com/docs/5.3/customize/color-modes/#javascript
I propose adding this to the template
steps that need to be taking:
data-bs-theme="light"
to base templatetheme-toggler.js
tostatic/js/
with this js codeI would argue that we should just add this but one could argue it should be added as a feature flag, what are your thoughts?
The text was updated successfully, but these errors were encountered: