Add dark mode support #5658
Open
Add dark mode support #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
111
to
+112
| <script defer src="{% static 'js/project.min.js' %}"></script> | ||
| <script defer src="{% static 'js/theme-toggler.js' %}"></script> |
There was a problem hiding this comment.
Would be nice if theme-toggler.js could be imported by project.js when using Gulp or Webpack. They will take care of bundling it nicely, I think.
| crossorigin="anonymous" | ||
| referrerpolicy="no-referrer" /> | ||
| <link rel="stylesheet" | ||
| href="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-icons/1.11.3/font/bootstrap-icons.min.css" |
There was a problem hiding this comment.
This need to be installed via npm when using Gulp or Webpack, and imported in project.scss:
@import '~bootstrap-icons/font/bootstrap-icons.css';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5629
Description
Checklist:
Rationale