-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: add signoz template #5386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
…etry, SMTP and email sending for Alert Manager
Is there any way to ignore the example secret from the XML, since it's not a real secret? |
@GauthierPLM Outstanding work! I just deployed it to test and it works. Two questions
![]() |
Hi @pkudinov
Since the docker compose exposes ports 4317 & 4318, you could also use the signoz service URL to call your machine, as long as the DNS return the machine IP (so no Cloudflare proxy).
|
4317&4318 are exposed and all good. I had to map them to subdomains in Cloudflare and all good. But JSON logs are not working through tracing, they require port |
@pkudinov in this case, I will keep them no exposed and will let users do the setup would it be needed. This will follow the official behavior and (hopefully) save some confusion. |
Maybe this issue will not occur when actually using the template over the UI, but for me, when using the template via a Docker Compose Service in Coolify, I had permissions issues with the After manually 777'ing the files in the |
@flawnn do you have more details on the error you encountered? I haven't found any issue on my side. |
+1 |
Shouldn't the container named init-clickhouse share the same volume as the actual clickhouse container |
Changes
Issues
Further testing and improvement suggestions are welcome! :)
In particular, I am not sure my approach is the best one to expose the OTEL collector.