-
Notifications
You must be signed in to change notification settings - Fork 6
[16.0][ADD] lpcr_pos_membership #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] lpcr_pos_membership #130
Conversation
9b155d5 to
4979e05
Compare
4979e05 to
2133c51
Compare
* avoid membership order lines with a quantity different than 1 (instead of higher than 1). * avoid membership order lines with no people assigned.
|
@flaenen is this still wip? it looks good to me. i added a commit to avoid some errors detected during functional testing. edit: is there some overlap with OCA/pos#1376 or is this different? |
huguesdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@huguesdk your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-130-by-huguesdk-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #130 +/- ##
==========================================
- Coverage 90.19% 87.45% -2.75%
==========================================
Files 20 32 +12
Lines 204 271 +67
Branches 17 22 +5
==========================================
+ Hits 184 237 +53
- Misses 14 28 +14
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c6ab2e4. Thanks a lot for contributing to coopiteasy. ❤️ |
Description
WIP
Odoo task (if applicable)
Checklist before approval