Skip to content

Conversation

@flaenen
Copy link
Contributor

@flaenen flaenen commented May 19, 2025

Description

WIP

Odoo task (if applicable)

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

@flaenen flaenen changed the title [ADD] lpcr_pos_membership [16.0][ADD] lpcr_pos_membership May 19, 2025
@flaenen flaenen force-pushed the 16.0-add-lpcr_pos_membership branch 2 times, most recently from 9b155d5 to 4979e05 Compare May 27, 2025 09:29
@flaenen flaenen force-pushed the 16.0-add-lpcr_pos_membership branch from 4979e05 to 2133c51 Compare May 27, 2025 17:37
* avoid membership order lines with a quantity different than 1 (instead
  of higher than 1).
* avoid membership order lines with no people assigned.
@huguesdk
Copy link
Member

huguesdk commented Jul 9, 2025

@flaenen is this still wip? it looks good to me.

i added a commit to avoid some errors detected during functional testing.

edit: is there some overlap with OCA/pos#1376 or is this different?

Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huguesdk
Copy link
Member

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-130-by-huguesdk-bump-nobump, awaiting test results.

github-grap-bot added a commit that referenced this pull request Jul 11, 2025
Signed-off-by huguesdk
@github-grap-bot
Copy link
Contributor

@huguesdk your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-130-by-huguesdk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (a50a63d) to head (c750aba).
Report is 41 commits behind head on 16.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             16.0     #130      +/-   ##
==========================================
- Coverage   90.19%   87.45%   -2.75%     
==========================================
  Files          20       32      +12     
  Lines         204      271      +67     
  Branches       17       22       +5     
==========================================
+ Hits          184      237      +53     
- Misses         14       28      +14     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@huguesdk
Copy link
Member

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-130-by-huguesdk-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 4a507f0 into coopiteasy:16.0 Jul 11, 2025
2 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at c6ab2e4. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants