Skip to content

[IMP] pos_membership_extension: consider membership in shopping cart #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

flaenen
Copy link

@flaenen flaenen commented Mar 18, 2025

Allow the sale of a product requiring membership if the membership product is in the shopping cart, even if the customer is not yet a member

Odoo task : T13569

legalsylvain and others added 30 commits July 2, 2024 11:26
…tail of the taxes. (Tax amount and base amount).
… the proxy + raise an error when its not properly configured
Currently translated at 75.0% (9 of 12 strings)

Translation: pos-16.0/pos-16.0-pos_daily_sales_reports_category_only
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_daily_sales_reports_category_only/es/
Signed-off-by legalsylvain
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_receipt_usability
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_receipt_usability/
Signed-off-by legalsylvain
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-16.0/pos-16.0-pos_payment_usability
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_usability/it/
Signed-off-by legalsylvain
Currently translated at 100.0% (5 of 5 strings)

Translation: pos-16.0/pos-16.0-pos_receipt_vat_detail
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_receipt_vat_detail/it/
Signed-off-by pedrobaeza
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-16.0/pos-16.0-pos_cash_control_override
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_cash_control_override/it/
Signed-off-by legalsylvain
mymage and others added 22 commits February 3, 2025 22:06
Currently translated at 100.0% (12 of 12 strings)

Translation: pos-16.0/pos-16.0-pos_container_deposit
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_container_deposit/it/
…house_id) of pos.config() have the same label: Warehouse. [Modules: pos_stock_available_online and point_of_sale]
…class(*classes) function to filter elements by their classes
Signed-off-by legalsylvain
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/
…rite on many items. (for exemple many quants)
Signed-off-by legalsylvain
Currently translated at 100.0% (19 of 19 strings)

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/it/
Recompute `sale.order` taxes, as received ones are the ones from
product, without fiscal position mapping applied.
Signed-off-by legalsylvain
@github-grap-bot
Copy link

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please do a PR against https://github.com/OCA/pos.

Please, edit the readme (by modifying files in readme folder) to explain your changes.

The sale of a product requiring membership is allowed if the membership product
is in the shopping cart, even if the customer is not yet a member.
@flaenen flaenen force-pushed the 16.0-allow_sales_with_membership branch from 06c69e9 to 9b42feb Compare March 19, 2025 17:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.65089% with 133 lines in your changes missing coverage. Please review.

Project coverage is 69.69%. Comparing base (6d9234b) to head (de170d5).
Report is 549 commits behind head on 16.0.

Files with missing lines Patch % Lines
pos_picking_delayed/models/pos_order.py 33.33% 24 Missing ⚠️
pos_picking_delayed/tests/test_module.py 32.25% 21 Missing ⚠️
pos_stock_available_online/models/stock_move.py 33.33% 14 Missing ⚠️
...vailable_online/models/stock_notifier_pos_mixin.py 38.88% 11 Missing ⚠️
..._loyalty_exclude/tests/test_pos_loyalty_exclude.py 50.00% 9 Missing ⚠️
pos_payment_description/models/pos_order.py 50.00% 7 Missing ⚠️
pos_cash_control_override/models/pos_session.py 45.45% 6 Missing ⚠️
..._default_partner/tests/test_pos_default_partner.py 33.33% 6 Missing ⚠️
...roduct_pricelist_alternative/models/pos_session.py 45.45% 6 Missing ⚠️
pos_loyalty_exclude/models/loyalty_rule.py 72.22% 4 Missing and 1 partial ⚠️
... and 10 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             16.0      #39       +/-   ##
===========================================
- Coverage   89.56%   69.69%   -19.88%     
===========================================
  Files         141      322      +181     
  Lines        1016     2445     +1429     
  Branches       88      139       +51     
===========================================
+ Hits          910     1704      +794     
- Misses         84      727      +643     
+ Partials       22       14        -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@remytms
Copy link
Member

remytms commented Mar 20, 2025

See : OCA#1341

@remytms remytms closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.