fix: Use .trivyignore from the terraform directory being checked instead repo root #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policy-bot-coop-norge
bot
requested review from
alfredosa,
AtzeDeVries,
bendiknesbo,
CRCOOP,
hadrienk,
irenemjs,
sachinchauhan23 and
siment
pravindahal
changed the title
pravindahal
changed the title
pravindahal
force-pushed
the
pravindahal/feat/implement-looing-for-trivyignore-in-terraform-directory
branch
from
8c856e8
to
8ec7289
Compare
AtzeDeVries
approved these changes
Oct 25, 2024
AtzeDeVries
approved these changes
Oct 28, 2024
pravindahal
changed the title
sachinchauhan23
approved these changes
Oct 28, 2024
pravindahal
deleted the
pravindahal/feat/implement-looing-for-trivyignore-in-terraform-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that trivyignore is not working as expected (as we have tried to use in cloud-projects: https://github.com/coopnorge/cloud-projects/pull/5160). It expects
.trivyignorein project root. We want to have it in the terraform directory (directories where the terraform files are).