[CORL-1464] Improve Subscription Memory Usage #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
force-pushed
the
fix/subscription-memory-fix
branch
from
f08e9b4
to
131c739
Compare
cvle
approved these changes
Oct 28, 2020
wyattjoh
added
the
🚀 merge it!
wyattjoh
added a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Thanks to the suggestion from @brettjashford over at apollographql/graphql-subscriptions#209 (comment) this provides an alternative implementation of the
withFilterthat uses native async iterators. This bypasses the issue with the workarounds existing in thegraphql-subscriptionspackage for older versions of NodeJS.What changes to the GraphQL/Database Schema does this PR introduce?
None.
How do I test this PR?
Try to perform some actions that would trigger traffic to go across the subscription system.